-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: mach-o certificate parsing implemented with der_parser #276
Conversation
Open to discussing how much CMS data we return. Currently we expose the following: Certificate {
issuer: c.x509.issuer.to_string(),
subject: c.x509.subject.to_string(),
is_self_signed: c.x509.issuer
== c.x509.subject,
} |
I would like to expose as much data as in the message Certificate {
optional string issuer = 1;
optional string subject = 2;
optional string thumbprint = 3;
optional int64 version = 4;
optional string algorithm = 5;
optional string algorithm_oid = 6;
optional string serial = 7;
optional int64 not_before = 8 [(yaml.field).fmt = "t"];
optional int64 not_after = 9 [(yaml.field).fmt = "t"];
} I guess this information is also available for Mach-O certificates, right? I would also add the |
As discussed in #235, implementing the certificate parsing with
der_parser
to reduce dependencies and potential headaches.Depends on #275, as the ASN.1 parsing functions were specific to PE before this PR.