Fix buffer overrun in "dotnet" module. #1167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Credits to OSS-Fuzz.
wxsBSD
approved these changes
Nov 15, 2019
tarterp
pushed a commit
to mandiant/yara
that referenced
this pull request
Mar 31, 2022
Credits to OSS-Fuzz.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The root cause of the buffer overrun is that
num_rowsis read directly from the size and can have an arbitrarily large value. There are some loops that increment a pointer on each iteration and try to read a structure from that pointer. Asnum_rowsis too high the pointer is incremented too many times and goes beyond the buffer's end.Credits to OSS-Fuzz.