Print module names. #1801
Print module names. #1801
Conversation
Add a -M option to the cli which will print the module names to stdout. As the number of modules has grown it can become confusing to know what modules are available, so this option will display them on stdout. NOTE: I'm not sure I like how I implemented this. It seems hackish to expose an API that just prints things on stdout but it felt even more hackish to walk the yr_modules_table array from outside of the module code. ;) Fixes VirusTotal#737.
libyara/modules.c
Outdated
| @@ -191,3 +191,9 @@ int yr_modules_unload_all(YR_SCAN_CONTEXT* context) | |||
|
|
|||
| return ERROR_SUCCESS; | |||
| } | |||
|
|
|||
| void yr_modules_print_names(void) | |||
There was a problem hiding this comment.
I think we should make this a proper API that returns the list of module names without printing it. You may want to get the list of modules for some other reason besides printing it to the console.
There was a problem hiding this comment.
Done, but I'm not sure you will like the name I went with: yr_modules_get_table(). I'm happy to rename it to something better if you have suggestions, maybe yr_modules_get_modules()?
Also, I'll update docs for this before merging.
Lastly, any thoughts on adding something like this to yara-python? I think it would be useful to be able to get that information from there too. I'll add it there if you agree.
There was a problem hiding this comment.
Yes, I think that adding it to yara-python may be useful too.
This adds a yr_modules_get_table to the libyara API so callers can get access to the modules. This is currently only used for printing the available module names in the yara cli. With this change it is now possible to expose this information in yara-python too.
Add a -M option to the cli which will print the module names to stdout. As the number of modules has grown it can become confusing to know what modules are available, so this option will display them on stdout.
NOTE: I'm not sure I like how I implemented this. It seems hackish to expose an API that just prints things on stdout but it felt even more hackish to walk the yr_modules_table array from outside of the module code. ;)
Fixes #737.