Merge pull request #457 from VisActor/fix/check-ACustomAnimate

Fix/check a custom animate
VisActor · May 13, 2024 · 14db5c2 · 14db5c2
2 parents 865f2ef + 7e7db9d
commit 14db5c2
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 1 deletion.
diff --git a/common/changes/@visactor/vgrammar-core/fix-check-ACustomAnimate_2024-05-11-07-08.json b/common/changes/@visactor/vgrammar-core/fix-check-ACustomAnimate_2024-05-11-07-08.json
@@ -0,0 +1,10 @@
+{
+  "changes": [
+    {
+      "packageName": "@visactor/vgrammar-core",
+      "comment": "fix: adapt custom animation to different vrender version",
+      "type": "none"
+    }
+  ],
+  "packageName": "@visactor/vgrammar-core"
+}
diff --git a/packages/vgrammar-core/src/graph/animation/animator.ts b/packages/vgrammar-core/src/graph/animation/animator.ts
@@ -21,7 +21,17 @@ Animate.mode |= AnimateMode.SET_ATTR_IMMEDIATELY;
 let GlobalAnimatorId = 0;
 
 const isCustomAnimateCtor = (custom?: IAnimationChannelInterpolator | IAnimationCustomConstructor) => {
-  return !isNil(custom) && custom.prototype instanceof ACustomAnimate;
+  if (isNil(custom)) {
+    return false;
+  }
+  return (
+    custom.prototype instanceof ACustomAnimate ||
+    // similar to ACustomAnimate, apply for different vrender version
+    ('onBind' in custom.prototype &&
+      'onStart' in custom.prototype &&
+      'onEnd' in custom.prototype &&
+      'onUpdate' in custom.prototype)
+  );
 };
 
 export class Animator implements IAnimator {