Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/animation config update #489

Merged
merged 3 commits into from
Jun 27, 2024
Merged

Fix/animation config update #489

merged 3 commits into from
Jun 27, 2024

Conversation

purpose233
Copy link
Contributor

@purpose233 purpose233 commented Jun 27, 2024

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Refactoring
  • Update dependency
  • Code style optimization
  • Test Case
  • Branch merge
  • Site / documentation update
  • Demo update
  • Workflow
  • Chore
  • Release
  • Other (about what?)

🔗 Related issue link

Fixed VisActor/VChart#2851

💡 Background and solution

  • fix the animation config update from valid animations to none animation;
  • add protection for final attributes in animations

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

copilot:summary

🔍 Walkthrough

copilot:walkthrough

@xile611 xile611 added this to the 0.13.12 milestone Jun 27, 2024
@xile611 xile611 merged commit 31d5f59 into develop Jun 27, 2024
3 of 4 checks passed
@xile611 xile611 deleted the fix/animation-config-update branch June 27, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] pie not draw when animation is false
2 participants