Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Depth.get_view(): fix normalization and add reverse cmap feature #150

Merged
merged 1 commit into from
Feb 14, 2022
Merged

Depth.get_view(): fix normalization and add reverse cmap feature #150

merged 1 commit into from
Feb 14, 2022

Conversation

jsalotti
Copy link
Contributor

Bug :

  • the cmap was not correctly normalized after clipping

Fix :

  • use vmin, vmax and clip arguments of matplotlib.colors.Normalize

Feature :

  • added reverse argument to use colormap in reverse order. Defaults to True to stay consistent with previous behavior.

@jsalotti jsalotti added bug Something isn't working aloscene aloscene labels Jan 31, 2022
@jsalotti jsalotti self-assigned this Jan 31, 2022
Johansmm
Johansmm approved these changes Feb 11, 2022
View reviewed changes
Copy link
Contributor

@Johansmm Johansmm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@thibo73800 thibo73800 merged commit dab73e8 into master Feb 14, 2022
@thibo73800 thibo73800 deleted the depth_get_view branch March 10, 2022 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Johansmm Johansmm Johansmm approved these changes

@thibo73800 thibo73800 thibo73800 approved these changes

Assignees

@jsalotti jsalotti

Labels
aloscene aloscene bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jsalotti @thibo73800 @Johansmm