Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optional trt import #215

Merged
merged 2 commits into from
Oct 4, 2022
Merged

Optional trt import #215

merged 2 commits into from
Oct 4, 2022

Conversation

thibo73800
Copy link
Contributor

  • Fix optional trt import : Fix an import issue in the calibrator. All trt and prod package must be optional

This pull request includes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Data-Iab
Data-Iab reviewed Aug 24, 2022
View reviewed changes
Copy link
Collaborator

@Data-Iab Data-Iab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that we can isolate prod packages just by removing this line, can't we ?

@thibo73800 thibo73800 merged commit b2c6acf into master Oct 4, 2022
@thibo73800 thibo73800 deleted the fix_optional_trt_import branch October 4, 2022 06:04
@thibo73800 thibo73800 restored the fix_optional_trt_import branch October 4, 2022 06:13
@thibo73800 thibo73800 mentioned this pull request Oct 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Data-Iab Data-Iab Data-Iab left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thibo73800 @Data-Iab