Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix kumler #235

Merged
merged 8 commits into from
Oct 27, 2022
Merged

Fix kumler #235

merged 8 commits into from
Oct 27, 2022

Conversation

anhtu293
Copy link
Contributor

@anhtu293 anhtu293 commented Oct 17, 2022 •
edited
Loading

Fix bugs in kumler-bauer projection support for aloscene.Depth

  • Fix bug X : Description
  • as_planar, as_euclidean: Assert error because the missing of "kumler_bauer" in verification condition.
  • as_points3d: missing of the calculation for distorted focal length for kumler_bauer.

This pull request includes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

@anhtu293 anhtu293 added bug Something isn't working aloscene aloscene labels Oct 17, 2022
@anhtu293 anhtu293 self-assigned this Oct 17, 2022
Data-Iab
Data-Iab requested changes Oct 17, 2022
View reviewed changes
aloscene/depth.py Outdated Show resolved Hide resolved
@Data-Iab Data-Iab merged commit db7f770 into master Oct 27, 2022
@Data-Iab Data-Iab deleted the fix-kumler branch October 27, 2022 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Data-Iab Data-Iab Data-Iab approved these changes

Assignees

@anhtu293 anhtu293

Labels
aloscene aloscene bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anhtu293 @Data-Iab