Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kitti: Documentation #288

Merged
merged 2 commits into from
Nov 18, 2022
Merged

Kitti: Documentation #288

merged 2 commits into from
Nov 18, 2022

Conversation

Ardorax
Copy link
Contributor

@Ardorax Ardorax commented Nov 18, 2022

Docstring on every class from Kitti dataset. Fix #286

This pull request includes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

@Ardorax
Kitti: Documentation
b709f39 
+ Docstring on every class from Kitti dataset.

Signed-off-by: Valentin Dury <valentin03dury@gmail.com>
@Ardorax Ardorax added documentation Improvements or additions to documentation invalid This doesn't seem right alodataset alobugdays labels Nov 18, 2022
@Ardorax Ardorax self-assigned this Nov 18, 2022
@Data-Iab Data-Iab self-requested a review November 18, 2022 09:32
Data-Iab
Data-Iab requested changes Nov 18, 2022
View reviewed changes
Copy link
Collaborator

@Data-Iab Data-Iab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add examples ?

@Ardorax
Example
460a163 
+ Example in docstring.
- Error in docstring.

Signed-off-by: Valentin Dury <valentin03dury@gmail.com>
@Ardorax Ardorax requested a review from Data-Iab November 18, 2022 10:22
@Data-Iab Data-Iab merged commit 2f0e71f into alobugdays Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Data-Iab Data-Iab Data-Iab approved these changes

Assignees

@Ardorax Ardorax

Labels
alobugdays alodataset documentation Improvements or additions to documentation invalid This doesn't seem right
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ardorax @Data-Iab