Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1 update samples #41

Merged
merged 7 commits into from
Sep 9, 2021
Merged

1 update samples #41

merged 7 commits into from
Sep 9, 2021

Conversation

Johansmm
Copy link
Contributor

@Johansmm Johansmm commented Sep 7, 2021

Features:

  • Fix links in BaseDatasets with news datasets.
  • Update Sintel and Flying datasets to use sample attribute.
  • Update unittest, with samples = True

Note:
There is a problem with WaymoDataset sample. In unittest/test_frame.py, a error is launch when sample is used:

Traceback (most recent call last):
  File "unittest/test_frame.py", line 523, in <module>
    test_frame_crop()
  File "unittest/test_frame.py", line 134, in test_frame_crop
    cropped_frame = frame[0, :, 400:900, 500:800]
  File "/home/johan/work/aloception/aloscene/tensors/augmented_tensor.py", line 225, in __getitem__
    name_to_n_label[name] = self.apply_on_label(
  File "/home/johan/work/aloception/aloscene/tensors/augmented_tensor.py", line 93, in apply_on_label
    return _apply_on_label(label, _func, on_list)
  File "/home/johan/work/aloception/aloscene/tensors/augmented_tensor.py", line 88, in _apply_on_label
    result = func(label)
  File "/home/johan/work/aloception/aloscene/tensors/augmented_tensor.py", line 92, in <lambda>
    _func = lambda l: None if l is None else func(l)
  File "/home/johan/work/aloception/aloscene/tensors/augmented_tensor.py", line 226, in <lambda>
    label, lambda l: self._getitem_label(l, name, idx), on_list=False
  File "/home/johan/work/aloception/aloscene/tensors/spatial_augmented_tensor.py", line 559, in _getitem_label
    label = _slice_list(label, 0, label_dim_idx, slicer)
  File "/home/johan/work/aloception/aloscene/tensors/spatial_augmented_tensor.py", line 510, in _slice_list
    n_slice = self.get_slices({label_list.names[dim_idx]: slicer}, label_list)
  File "/home/johan/work/aloception/aloscene/tensors/augmented_tensor.py", line 672, in get_slices
    assert not any(
AssertionError: One of the desired slice dim name is not in the current names of this augmented tensor.

Merge until this problem is solved.

@Johansmm Johansmm assigned Johansmm and unassigned thibo73800 Sep 7, 2021
@Johansmm Johansmm added the enhancement New feature or request label Sep 7, 2021
Copy link
Contributor

@thibo73800 thibo73800 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, before to merge. In order to be consistent with other main method, I think we must make sure that all main of each datasets used the sample instead of the real dataset.

@Johansmm
Copy link
Contributor Author

Johansmm commented Sep 8, 2021

@thibo73800 all datasets was tested with .get, .getitem, stream_loader and train_loader functions.
Also, the download links were tested.
Ready to review

thibo73800
thibo73800 previously approved these changes Sep 9, 2021
Copy link
Contributor

@thibo73800 thibo73800 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok to be merged, should I update the online sample with /data/samples ?

@thibo73800 thibo73800 dismissed their stale review September 9, 2021 06:11

Unit test failed

@thibo73800
Copy link
Contributor

Unit tests do not work on my side. Maybe because I need to update the sample first ?

@thibo73800 thibo73800 merged commit c64dae3 into master Sep 9, 2021
@thibo73800 thibo73800 deleted the 1-update-samples branch September 9, 2021 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alodataset enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants