Run from run_ID #68
Merged
Run from run_ID #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thibo73800
requested changes
Sep 16, 2021
alonet/common/pl_helpers.py
Outdated
| @@ -71,6 +71,7 @@ def add_argparse_args(parent_parser, add_pl_args=True, mode="training"): | |||
| parser.add_argument("--project_run_id", type=str, help="Project related with the run ID to load") | |||
| parser.add_argument("--expe_name", type=str, default=None, help="expe_name to be logged in wandb") | |||
| parser.add_argument("--no_suffix", action="store_true", help="do not add date suffix to expe_name") | |||
| parser.add_argument("--nostrict", action="store_false", help="load from checkpoint to run a model with different weights (default True)") | |||
There was a problem hiding this comment.
Usually if one use --nostrict the expected behavior is : Do not strictly load the weights (store true on nostrict)
But here --nostrict set nostrict to false. It seem to me to be counter intuitive.
There was a problem hiding this comment.
now if --nostrict is specified (store True and False by default) it is possible to load a checkpoint with different keys in the load_state_dict. BUT it is still not possible for a checkpoint with same keys but different values (weights dimensions).
thibo73800
approved these changes
Sep 16, 2021
thibo73800
approved these changes
Sep 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when launching a train after having loaded a checkpoint, parameters of the initial model were not kept and default parameters replaced them. It's fixed.
new parse argument "--nostrict" used if we want to run a model from a checkpoint, with different coefficients between the model and the model that generated the checkpoint.