Skip to content
This repository has been archived by the owner on Aug 17, 2021. It is now read-only.

Add action parameter for v3 execution. #240

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add action parameter for v3 execution. #240

wants to merge 1 commit into from

Conversation

muliyul
Copy link

@muliyul muliyul commented Feb 3, 2019

@coveralls
Copy link

Coverage Status

Coverage remained the same at 95.0% when pulling ec0a3d0 on muliyul:develop into 73d01e4 on VividCortex:master.

@holls91
Copy link

holls91 commented Apr 3, 2020

Can someone with write access merge this pull request? Thanks!

iambrosi
iambrosi suggested changes Apr 3, 2020
View reviewed changes
Copy link
Contributor

@iambrosi iambrosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@muliyul Can you please add a mention about using the action setting to the README?

mtrias
mtrias reviewed Apr 3, 2020
View reviewed changes
src/service.js
*/
execute: function (widgetId) {
execute: function (widgetId, action) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

recaptcha expects that the provided action is a string. Do we know that it tollerates undefined ?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mtrias mtrias mtrias left review comments

@iambrosi iambrosi iambrosi requested changes

@TheSharpieOne TheSharpieOne TheSharpieOne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@muliyul @coveralls @holls91 @iambrosi @TheSharpieOne @mtrias