You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
Hello, I think there's a problem in the way you export the module. When I follow the documentation, I get the following error:
Uncaught TypeError: _bulmajs2.default.create is not a function
I think it's because you don't export the module properly on bulma.js.
Also, I think you should remove window.Bulma = Bulma; from the same file. This should be left to the user to decide. And, if you import the library this way import '@vizuaalog/bulmajs', it will work thanks to the windows assignment thus adding to the confusion.
Good spot! The export is wrong. I also think you're right about the window point. It was originally changed to make it easier to import, but there has been other changes that does make this irrelevant now.
Versions
BulmaJS: 0.7.0
Browser: irrelevant
Operating system: irrelevant
Describe the bug
Hello, I think there's a problem in the way you export the module. When I follow the documentation, I get the following error:
Uncaught TypeError: _bulmajs2.default.create is not a function
I think it's because you don't export the module properly on bulma.js.
Also, I think you should remove
window.Bulma = Bulma;
from the same file. This should be left to the user to decide. And, if you import the library this wayimport '@vizuaalog/bulmajs'
, it will work thanks to the windows assignment thus adding to the confusion.I can submit a PR if needed.
Thank you!
To Reproduce
Produces
Uncaught TypeError: _bulmajs2.default.create is not a function
Fix
On bulma.js add the following line:
export default Bulma
and remove the following line:
window.Bulma = Bulma;
The text was updated successfully, but these errors were encountered: