Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix selected list positioning bug #35

Merged
merged 1 commit into from
Aug 22, 2019
Merged

Fix selected list positioning bug #35

merged 1 commit into from
Aug 22, 2019

Conversation

tsubik
Copy link
Contributor

@tsubik tsubik commented Aug 20, 2019

Pasted Image at 2019_08_20_11_01 pm

@tsubik tsubik requested a review from kowal August 20, 2019 21:44
@kowal
Copy link
Contributor

kowal commented Aug 22, 2019 •
edited
Loading

For reference - this was fixed in select2 4.0.9 in Fix dropdown positioning when displayed above with messages (#5592)), however rails wrapper is still on version 4.0.3 :(. We could create our own fork of select2-rails with 4.0.9 bundled and use it. Since it can break other things let's consider it as a separate technical task.

kowal
kowal approved these changes Aug 22, 2019
View reviewed changes
Copy link
Contributor

@kowal kowal left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 for now, but I think we should upgrade to select2 4.0.9 at some point.

Edit: it won't be so simple because it needs to go through https://github.com/platanus/activeadmin_addons.

@tsubik tsubik merged commit cb45831 into develop Aug 22, 2019
@kowal kowal deleted the fix/selected-list-positioning branch August 22, 2019 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kowal kowal kowal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tsubik @kowal