Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore/upload import cleanup #41

Merged
merged 4 commits into from
Aug 27, 2019
Merged

Chore/upload import cleanup #41

merged 4 commits into from
Aug 27, 2019

Conversation

kowal
Copy link
Contributor

@kowal kowal commented Aug 26, 2019

Summary

  • rename BaseUploader to BaseImporter
  • rename & unify details/stats to upload_results
  • rename import_each_with_logging to import_each_csv_row
  • do not call parse_csv twice during import

@kowal kowal requested a review from tsubik August 26, 2019 15:33
tsubik
tsubik approved these changes Aug 27, 2019
View reviewed changes
Copy link
Contributor

@tsubik tsubik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 Feel free to merge it any time.

app/services/csv_import/base_importer.rb Outdated

def initialize(file)
@file = file
@import_results ||= {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here could be only =

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@kowal kowal merged commit 5322243 into develop Aug 27, 2019
@kowal kowal deleted the chore/upload-import-cleanup branch August 27, 2019 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsubik tsubik tsubik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kowal @tsubik