Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add react rails #90

Merged
merged 4 commits into from
Nov 6, 2019
Merged

Add react rails #90

merged 4 commits into from
Nov 6, 2019

Conversation

aabdaab
Copy link
Contributor

@aabdaab aabdaab commented Nov 6, 2019

This small PR sets up react-rails gem to use React for more interactive widgets like Bubble Chart.
Read README for more info but long story short, that allows us to create react components in app/javascript/components and use them in erb files like so:

<%= react_component("HelloWorld", { greeting: "Hello from react-rails." }) %>

The first argument being component's name and second being props. HelloWorld added for demonstration.

I also added the number of companies in the center of the PieChart (not ideally styled yet) /tpi/sectors - check here

@rapzo
Copy link
Contributor

rapzo commented Nov 6, 2019

Must we do it The Rails Way™? We could achieve the same with a PWA imho.
Personal preference, is all.

@simaob
Copy link
Contributor

simaob commented Nov 6, 2019

given the time pressure I'd go with something we know already and are comfortable with. Reduce the risks as much as possible.

@aabdaab
Copy link
Contributor Author

aabdaab commented Nov 6, 2019

The Rails Way was precisely what I wanted to avoid 😅 That's why I added react-rails, what do you mean exactly?

@tsubik
Copy link
Contributor

tsubik commented Nov 6, 2019

Ok, let's do BubbleChart component with some default text for now instead of HelloWorld one.

@aabdaab
Copy link
Contributor Author

aabdaab commented Nov 6, 2019

@tsubik done 👍

Copy link
Contributor

@tsubik tsubik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can also remove that hello_react pack.

@aabdaab
Copy link
Contributor Author

aabdaab commented Nov 6, 2019

done

Copy link
Contributor

@simaob simaob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm =)

@tsubik tsubik self-requested a review November 6, 2019 16:51
@simaob simaob merged commit 80a4e78 into develop Nov 6, 2019
@simaob simaob deleted the feature/add-react-rails branch November 6, 2019 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants