-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add react rails #90
Add react rails #90
Conversation
Must we do it The Rails Way™? We could achieve the same with a PWA imho. |
given the time pressure I'd go with something we know already and are comfortable with. Reduce the risks as much as possible. |
The Rails Way was precisely what I wanted to avoid 😅 That's why I added |
Ok, let's do BubbleChart component with some default text for now instead of HelloWorld one. |
@tsubik done 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can also remove that hello_react pack.
done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm =)
This small PR sets up
react-rails
gem to use React for more interactive widgets likeBubble Chart
.Read README for more info but long story short, that allows us to create react components in
app/javascript/components
and use them inerb
files like so:The first argument being component's name and second being
props
. HelloWorld added for demonstration.I also added the number of companies in the center of the PieChart (not ideally styled yet)
/tpi/sectors
- check here