Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/marxan 1474 shapefile missing components error #1034

Merged

Conversation

AaronPerezPerez
Copy link
Contributor

@AaronPerezPerez AaronPerezPerez commented May 4, 2022

Ensure there exists all required components

Overview

For error handling, we need to ensure that a shapefile has all the required components.
This PR adds:

  • A helper function to ensure all files exists, and in case some is missing it throws a 400 error with a descriptive message
  • Uses the new function where it's needed to stop the flow in case some piece is missing

Related issue

MARXAN-1474

@vercel
Copy link

vercel bot commented May 4, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
marxan ✅ Ready (Inspect) Visit Preview May 4, 2022 at 0:19AM (UTC)
marxan-storybook ✅ Ready (Inspect) Visit Preview May 4, 2022 at 0:19AM (UTC)

@AaronPerezPerez AaronPerezPerez merged commit f4438ad into develop May 4, 2022
@AaronPerezPerez AaronPerezPerez deleted the fix/MARXAN-1474-shapefile-missing-components-error branch May 4, 2022 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants