MARXAN-1609-projects-sources-column #1110

rubvalave · 2022-05-25T10:44:17Z

-Adds migration to add sources column and enum type to projects table.

…lumn enum

vercel · 2022-05-25T10:44:20Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
marxan	✅ Ready (Inspect)	Visit Preview	May 27, 2022 at 11:40AM (UTC)
marxan-storybook	✅ Ready (Inspect)	Visit Preview	May 27, 2022 at 11:40AM (UTC)

aciddaute · 2022-05-26T11:36:32Z

I think the migration is perfectly fine but I'm missing two things:

We should update Project Typeorm api entity to reflect the new column
We should create project shell specifying as sources value legacy-import when importing legacy projects (createShells method in api/apps/api/src/modules/legacy-project-import/application/start-legacy-project-import.handler.ts)

…ell for legacy import

api/apps/api/src/modules/projects/project.api.entity.ts

feat: adds migration for column sources in projects, adds specific co…

9363395

…lumn enum

rubvalave requested review from aciddaute and angelhigueraacid May 25, 2022 10:44

rubvalave self-assigned this May 25, 2022

vercel bot deployed to Preview – marxan May 25, 2022 10:44 View deployment

feat: solve missing characters in query

1312f73

vercel bot deployed to Preview – marxan-storybook May 25, 2022 13:46 View deployment

vercel bot deployed to Preview – marxan May 25, 2022 13:47 View deployment

feat: adds sources to project entity, adds sources info to project sh…

4ee0fb5

…ell for legacy import

vercel bot deployed to Preview – marxan-storybook May 27, 2022 07:44 View deployment

vercel bot deployed to Preview – marxan May 27, 2022 07:45 View deployment

aciddaute suggested changes May 27, 2022

View reviewed changes

api/apps/api/src/modules/projects/project.api.entity.ts Outdated Show resolved Hide resolved

feat: adds proper default for sources column in api entity

331fb56

vercel bot deployed to Preview – marxan-storybook May 27, 2022 10:59 View deployment

vercel bot deployed to Preview – marxan May 27, 2022 10:59 View deployment

feat: fix input file unit tests missing sources

560dfbd

vercel bot deployed to Preview – marxan-storybook May 27, 2022 11:39 View deployment

vercel bot deployed to Preview – marxan May 27, 2022 11:40 View deployment

aciddaute approved these changes May 27, 2022

View reviewed changes

rubvalave merged commit 9bbe5ca into develop May 27, 2022

rubvalave deleted the MARXAN-1609-sources-projects-table branch May 27, 2022 12:39

Provide feedback