Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(front): registration form extension + picky details [MARXAN-1394][MARXAN-1396][MARXAN-1311] #1143

Merged
merged 9 commits into from
Jun 28, 2022
Merged

feat(front): registration form extension + picky details [MARXAN-1394][MARXAN-1396][MARXAN-1311] #1143

merged 9 commits into from
Jun 28, 2022

Conversation

anamontiaga
Copy link
Collaborator

@anamontiaga anamontiaga commented Jun 20, 2022 •
edited
Loading

Registration form extension + picky details

Overview

Picky details:

  • Make the “5 most different solutions“ text clickable adding id to label.
  • Add more space between the sentence and the buttons on delete Configuration Prompt component.

Add fields to sign up form:

  • Country.
  • Nature of work with Marxan (separate in two selects).

Designs

There are no designs.

Testing instructions

The answers of the added questions are not reflected in the frontend. You have to check if they are arriving correctly at the BE.

We still need add a new icon to the country input (just asked for design).

Screenshot 2022-06-21 at 18 26 56

Feature relevant tickets

MARXAN-1394
MARXAN-1396
MARXAN-1311

@vercel
Copy link

vercel bot commented Jun 20, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
marxan ✅ Ready (Inspect) Visit Preview Jun 28, 2022 at 9:43AM (UTC)
marxan-storybook ✅ Ready (Inspect) Visit Preview Jun 28, 2022 at 9:43AM (UTC)

@anamontiaga anamontiaga added Frontend Everything related frontend WIP Work in progress labels Jun 20, 2022
@anamontiaga anamontiaga added Ready to review PR ready to review and removed WIP Work in progress labels Jun 21, 2022
@anamontiaga anamontiaga requested a review from mbarrenechea June 21, 2022 16:28
@anamontiaga anamontiaga changed the base branch from develop to demo June 28, 2022 09:44
@anamontiaga anamontiaga changed the base branch from demo to vercel-demo June 28, 2022 09:44
@mbarrenechea mbarrenechea merged commit c2999b5 into vercel-demo Jun 28, 2022
@mbarrenechea mbarrenechea deleted the feat/front/MARXAN-1311-registration-form-extension branch June 28, 2022 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbarrenechea mbarrenechea Awaiting requested review from mbarrenechea

Assignees
No one assigned
Labels
Frontend Everything related frontend Ready to review PR ready to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anamontiaga @mbarrenechea