Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wrong update of exisiting scenario features data in migration #1157

Merged

Conversation

angelhigueraacid
Copy link
Contributor

This PR fixes the update of existing scenario_features_data rows when adding api_feature_id

Feature relevant tickets

set api_feature_id for existing features: fix migration

@angelhigueraacid angelhigueraacid requested a review from hotzevzl July 5, 2022 10:19
@angelhigueraacid angelhigueraacid self-assigned this Jul 5, 2022
@vercel
Copy link

vercel bot commented Jul 5, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
marxan ✅ Ready (Inspect) Visit Preview Jul 5, 2022 at 10:22AM (UTC)
marxan-storybook ✅ Ready (Inspect) Visit Preview Jul 5, 2022 at 10:22AM (UTC)

Copy link
Member

@hotzevzl hotzevzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @angelhigueraacid - this saves my planned deployments for the day (and unbreaks local dev environments if any dev has features by the time this migration tries to run 😬)

@hotzevzl hotzevzl merged commit 7e60c25 into develop Jul 5, 2022
@hotzevzl hotzevzl deleted the feat/MARXAN-1674-set-api_feature_id-for-existing-features branch July 5, 2022 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants