update puvspr.dat entries [MARXAN-946] #1158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
hotzevzl
approved these changes
Jul 12, 2022
There was a problem hiding this comment.
thanks @angelhigueraacid!
all looks good - I have left a bunch of typo and minor comments.
the two main bits to consider more carefully are my comment about PuvsprDatLegacyProject.getLegacyAndMarxanFeatures() and on whether we should add a FK from the calculations table to projects_pu (at the expense of... an extra join or queries to get the value to write?)
...ps/api/src/migrations/api/1656497708461-AddGeoOperationHashAndGeoOperationToFeaturesTable.ts
Outdated
Show resolved
Hide resolved
api/apps/api/src/modules/features-hash/strip-single-split-config-feature-value.service.spec.ts
Show resolved
Hide resolved
api/apps/api/src/modules/features-hash/strip-single-split-config-feature-value.service.spec.ts
Show resolved
Hide resolved
api/apps/api/src/modules/features-hash/strip-single-split-config-feature-value.service.spec.ts
Show resolved
Hide resolved
api/apps/api/src/modules/scenarios/input-files/puvspr.dat.processor/puvspr.dat.processor.ts
Show resolved
Hide resolved
api/apps/api/test/integration/single-config-feature-value.hasher.e2e-spec.ts
Show resolved
Hide resolved
...apps/geoprocessing/src/migrations/geoprocessing/1655819134885-AddsPuvsprCalculationsTable.ts
Show resolved
Hide resolved
hotzevzl
changed the title
angelhigueraacid
force-pushed
the
feat/MARXAN-946-update-puvspr.dat-entries
branch
from
3ee09ca to
504a7e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the way
puvspr.datfile is generated. Now, the calculations are made once acreated specificationis made, for each of the features selected in the specification, the calculation will be performed and stored, in order to retrieve this results when creating puvspr.dat file.In case the project is a legacy project, no calculations will be performed for any feature within the specification. Also, this PR adds
SplitCreateFeaturesused for creating one feature per subset contained within a split feature.Another PR will be created for exporting and importing the puvspr_calculations made for project features.
Feature relevant tickets
update puvspr.dat entries only for changed/added/deleted features