Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove feature tags [MARXAN-1679] #1167

Merged
merged 1 commit into from
Jul 14, 2022
Merged

remove feature tags [MARXAN-1679] #1167

merged 1 commit into from
Jul 14, 2022

Conversation

hotzevzl
Copy link
Member

@vercel
Copy link

vercel bot commented Jul 11, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
marxan ✅ Ready (Inspect) Visit Preview Jul 11, 2022 at 6:46PM (UTC)
marxan-storybook ✅ Ready (Inspect) Visit Preview Jul 11, 2022 at 6:46PM (UTC)

@hotzevzl hotzevzl marked this pull request as draft July 11, 2022 14:51
@hotzevzl hotzevzl force-pushed the chore/api/MARXAN-1679_remove-feature-tags branch from a4d5fdf to 2eec9d8 Compare July 11, 2022 14:58
@hotzevzl hotzevzl force-pushed the chore/api/MARXAN-1679_remove-feature-tags branch from 2eec9d8 to 254c8c1 Compare July 11, 2022 15:40
@hotzevzl hotzevzl force-pushed the chore/api/MARXAN-1679_remove-feature-tags branch from 254c8c1 to ddff62a Compare July 11, 2022 15:44
@hotzevzl hotzevzl marked this pull request as ready for review July 11, 2022 16:46
@hotzevzl hotzevzl requested review from rubvalave and aagm July 11, 2022 17:04
@hotzevzl hotzevzl force-pushed the chore/api/MARXAN-1679_remove-feature-tags branch from ddff62a to 2298e18 Compare July 11, 2022 18:42
rubvalave
rubvalave approved these changes Jul 14, 2022
View reviewed changes
Copy link
Contributor

@rubvalave rubvalave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! It is just a case of removing completely all the references to a specific column everywhere along the app, right?

@hotzevzl
Copy link
Member Author

LGTM! It is just a case of removing completely all the references to a specific column everywhere along the app, right?

yep, and the related enums (both in db and TS code).

@hotzevzl hotzevzl merged commit 2e7d113 into develop Jul 14, 2022
@hotzevzl hotzevzl deleted the chore/api/MARXAN-1679_remove-feature-tags branch July 14, 2022 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rubvalave rubvalave rubvalave approved these changes

@aagm aagm Awaiting requested review from aagm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hotzevzl @rubvalave