Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[api] fixes csv features upload to save features as is_legacy=true for correct puvspr.dat generation [MRXN23-279] #1421

Merged

Conversation

yulia-bel
Copy link
Contributor

Fix saving features uploaded with cs file

Overview

Small fix that sets new features, uploaded with csv file, to have value is_legacy=true. After csv feature upload project sources has already been being set to legacy_import. Setting features as legacy was missing for correct data generation made by PuvsprDatLegacyProject.getAmountPerPlanningUnitAndFeature()

Designs

Link to the related design prototypes (if applicable)

Testing instructions

Upload features from csv file to a projects scenario. New features must have is_legacy=true in (apiDB).featuresTable.
Generating puvspr.dat file must return amounts per species per planning units in accordance with csv file data (not an empty table as it is now).

Feature relevant tickets

Link to the related task manager tickets


Checklist before submitting

  • Meaningful commits and code rebased on develop.
  • If this PR adds feature that should be tested for regressions when
    deploying to staging/production, please add brief testing instructions
    to the deploy checklist (docs/deployment-checklist.md)
  • Update CHANGELOG file

@yulia-bel yulia-bel requested a review from hotzevzl August 3, 2023 15:03
@yulia-bel yulia-bel merged commit d1b7fd1 into develop Aug 4, 2023
@yulia-bel yulia-bel deleted the fix/api/MRXN23-279-csv-uploaded-features-data-in-dat-file branch August 4, 2023 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants