only mark scenario as run once it finished running successfully [MRXN23-280] #1431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@yulia-bel don't forget a |
yulia-bel
force-pushed
the
chore/api/MRXN23-280_only-mark-scenario-as-run-once-it-finished-running-successfully
branch
from
a5e77e0 to
a2916bd
Compare
|
@yulia-bel thanks! let's merge 🚀 |
yulia-bel
deleted the
chore/api/MRXN23-280_only-mark-scenario-as-run-once-it-finished-running-successfully
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only mark a scenario as
ranAtLeastOnce: trueafter it has run fully and successfully.Testing instructions
Create new scenario, set it to run with a high enough number of iteration to give some time to check if the
Scenario.ranAtLeastOnceflag is flipped from the initial default (false) totruewhile the Marxan solver is running.Without this PR, the property should be flipped almost instantly after pressing the Run button (or triggering a marxan run via the API directly). With this PR, the property should only be flipped to
trueonly after Marxan has run fully and successfully (so, it should stayfalseif the Marxan run is interrupted in flight or fails for whatever reason.Feature relevant tickets
https://vizzuality.atlassian.net/browse/MRXN23-280
Checklist before submitting
develop.deploying to staging/production, please add brief testing instructions
to the deploy checklist (
docs/deployment-checklist.md)