Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(api): projects: jobs status #253

Merged
merged 7 commits into from
Jun 16, 2021
Merged

feat(api): projects: jobs status #253

merged 7 commits into from
Jun 16, 2021

Conversation

kgajowy
Copy link
Contributor

@kgajowy kgajowy commented Jun 9, 2021

Substitute this line for a meaningful title for your changes

Overview

Please write a description. If the PR is hard to understand, provide a quick explanation of the code.

Designs

Link to the related design prototypes (if applicable)

Testing instructions

Please explain how to test the PR: ID of a dataset, steps to reach the feature, etc.

Feature relevant tickets

Link to the related task manager tickets

Checklist before submitting

  • Meaningful commits and code rebased on develop.
  • If this PR adds feature that should be tested for regressions when
    deploying to staging/production, please add brief testing instructions
    to the deploy checklist (docs/deployment-checklist.md)
  • Update CHANGELOG file

@vercel
Copy link

vercel bot commented Jun 9, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

marxan – ./app

🔍 Inspect: https://vercel.com/vizzuality1/marxan/9oDVgRUvia949VhvnrprvmspUVPr
✅ Preview: https://marxan-git-api-project-job-status-vizzuality1.vercel.app

marxan-storybook – ./app

🔍 Inspect: https://vercel.com/vizzuality1/marxan-storybook/2dpEACvVgGcQ3xvYQP7tAdn2Dxh9
✅ Preview: https://marxan-storybook-git-api-project-job-status-vizzuality1.vercel.app

@kgajowy kgajowy force-pushed the api/project-job-status branch from bf9e5e9 to 210e0aa Compare June 9, 2021 08:42
@Dyostiq Dyostiq force-pushed the api/project-job-status branch from 1a756ac to babc315 Compare June 9, 2021 10:40
@Dyostiq Dyostiq force-pushed the api/project-job-status branch from 57411c9 to ea3ed19 Compare June 11, 2021 09:57
@Dyostiq Dyostiq marked this pull request as ready for review June 11, 2021 09:58
@kgajowy kgajowy requested review from hotzevzl and aagm June 11, 2021 13:57
hotzevzl
hotzevzl approved these changes Jun 16, 2021
View reviewed changes
Copy link
Member

@hotzevzl hotzevzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok overall, thank you.

it would be useful to include a sample file that allows to see the job statuses actually transition.

@aagm was seeing some issues with project and scenario creation in this branch, but from very quick checks I am not sure this is a regression - we should check in any case.

api/apps/api/src/modules/projects/job-status/job-status.view.api.entity.ts Outdated Show resolved Hide resolved
api/apps/api/src/modules/projects/job-status/job-status.view.api.entity.ts Outdated Show resolved Hide resolved
@kgajowy
Copy link
Contributor Author

kgajowy commented Jun 16, 2021

@hotzevzl was seeing some issues with project and scenario creation in this branch what issues exactly happened?

@Dyostiq Dyostiq requested a review from hotzevzl June 16, 2021 07:22
@kgajowy kgajowy merged commit 784f36a into develop Jun 16, 2021
@kgajowy kgajowy deleted the api/project-job-status branch June 16, 2021 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dyostiq Dyostiq Dyostiq left review comments

@hotzevzl hotzevzl hotzevzl approved these changes

@aagm aagm Awaiting requested review from aagm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kgajowy @Dyostiq @hotzevzl