-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MARXAN-446] planning area assigning #299
Conversation
This pull request is being automatically deployed with Vercel (learn more). marxan – ./app🔍 Inspect: https://vercel.com/vizzuality1/marxan/7MvkZKLtffrQp53bQVahYH8zEqn6 marxan-storybook – ./app🔍 Inspect: https://vercel.com/vizzuality1/marxan-storybook/DWqbvr8ZxoNvitVcUau7m5heqY4B |
00c8ac5
to
fbb7c45
Compare
7f556ac
to
b25bbbe
Compare
@@ -51,6 +51,14 @@ INSERT INTO "planning_areas"("the_geom") | |||
} | |||
|
|||
async assignProject(id: string, projectId: string): Promise<void> { | |||
await this.planningAreas.update( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in practice we could even delete this planning area straight away rather than orphaning it and letting it be GC'ed later on (but we'd need to do this in a transaction to make sure the delete can be rolled back if the successive update fails
32e931a
to
ed1f455
Compare
66f7d0e
to
735615b
Compare
ed1f455
to
bd30b05
Compare
735615b
to
d321a1b
Compare
d321a1b
to
600d682
Compare
Substitute this line for a meaningful title for your changes
Overview
Please write a description. If the PR is hard to understand, provide a quick explanation of the code.
Designs
Link to the related design prototypes (if applicable)
Testing instructions
Please explain how to test the PR: ID of a dataset, steps to reach the feature, etc.
Feature relevant tickets
Link to the related task manager tickets
Checklist before submitting
develop
.deploying to staging/production, please add brief testing instructions
to the deploy checklist (
docs/deployment-checklist.md
)