Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MARXAN-446] planning area assigning #299

Merged
merged 3 commits into from
Jul 7, 2021

Conversation

Dyostiq
Copy link
Contributor

@Dyostiq Dyostiq commented Jun 30, 2021

Substitute this line for a meaningful title for your changes

Overview

Please write a description. If the PR is hard to understand, provide a quick explanation of the code.

Designs

Link to the related design prototypes (if applicable)

Testing instructions

Please explain how to test the PR: ID of a dataset, steps to reach the feature, etc.

Feature relevant tickets

Link to the related task manager tickets


Checklist before submitting

  • Meaningful commits and code rebased on develop.
  • If this PR adds feature that should be tested for regressions when
    deploying to staging/production, please add brief testing instructions
    to the deploy checklist (docs/deployment-checklist.md)
  • Update CHANGELOG file

@vercel
Copy link

vercel bot commented Jun 30, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

marxan – ./app

🔍 Inspect: https://vercel.com/vizzuality1/marxan/7MvkZKLtffrQp53bQVahYH8zEqn6
✅ Preview: https://marxan-git-feature-marxan-446-planning-area-748bbd-vizzuality1.vercel.app

marxan-storybook – ./app

🔍 Inspect: https://vercel.com/vizzuality1/marxan-storybook/DWqbvr8ZxoNvitVcUau7m5heqY4B
✅ Preview: https://marxan-storybook-git-feature-marxan-446-plan-c6f806-vizzuality1.vercel.app

@@ -51,6 +51,14 @@ INSERT INTO "planning_areas"("the_geom")
}

async assignProject(id: string, projectId: string): Promise<void> {
await this.planningAreas.update(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in practice we could even delete this planning area straight away rather than orphaning it and letting it be GC'ed later on (but we'd need to do this in a transaction to make sure the delete can be rolled back if the successive update fails

@Dyostiq Dyostiq force-pushed the feature/MARXAN-475-swagger-docs branch 2 times, most recently from 32e931a to ed1f455 Compare July 7, 2021 07:18
@Dyostiq Dyostiq force-pushed the feature/MARXAN-446-planning-area-assigning branch from 66f7d0e to 735615b Compare July 7, 2021 07:23
@Dyostiq Dyostiq force-pushed the feature/MARXAN-475-swagger-docs branch from ed1f455 to bd30b05 Compare July 7, 2021 09:11
@Dyostiq Dyostiq force-pushed the feature/MARXAN-446-planning-area-assigning branch from 735615b to d321a1b Compare July 7, 2021 09:12
Base automatically changed from feature/MARXAN-475-swagger-docs to develop July 7, 2021 09:31
@Dyostiq Dyostiq force-pushed the feature/MARXAN-446-planning-area-assigning branch from d321a1b to 600d682 Compare July 7, 2021 09:45
@Dyostiq Dyostiq merged commit 809d4aa into develop Jul 7, 2021
@Dyostiq Dyostiq deleted the feature/MARXAN-446-planning-area-assigning branch July 7, 2021 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants