feat(api): pass assets to marxan run job #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). marxan – ./app🔍 Inspect: https://vercel.com/vizzuality1/marxan/EVZwyUzW3QR42YddctyD4wVpmbxu marxan-storybook – ./app🔍 Inspect: https://vercel.com/vizzuality1/marxan-storybook/6KNCdxovPqdY9oUaG1TtzeejseQB |
Dyostiq
requested review from
kgajowy and
hotzevzl
and removed request for
kgajowy
Dyostiq
force-pushed
the
feature/MARXAN-305-scenario-run-api-side
branch
from
7180f14 to
356fdf3
Compare
Dyostiq
force-pushed
the
feature/MARXAN-305-pass-assets-to-run-job
branch
from
1219507 to
75f1f5d
Compare
kgajowy
approved these changes
Jul 12, 2021
api/apps/api/src/modules/scenarios/marxan-run/input-parameter-file.provider.ts
Outdated
Show resolved
Hide resolved
Comment on lines
+2
to
+5
| export type Assets = { | ||
| url: string; | ||
| relativeDestination: string; | ||
| }[]; |
There was a problem hiding this comment.
Would be great to add a subtask to use this in geoprocessing ❤️ 🙇
hotzevzl
approved these changes
Jul 13, 2021
Dyostiq
force-pushed
the
feature/MARXAN-305-scenario-run-api-side
branch
from
356fdf3 to
1ab1de1
Compare
Base automatically changed from
feature/MARXAN-305-scenario-run-api-side
to
develop
July 14, 2021 10:22
Dyostiq
force-pushed
the
feature/MARXAN-305-pass-assets-to-run-job
branch
from
75f1f5d to
074e20d
Compare
Dyostiq
force-pushed
the
feature/MARXAN-305-pass-assets-to-run-job
branch
from
074e20d to
a08ce99
Compare
Dyostiq
force-pushed
the
feature/MARXAN-305-pass-assets-to-run-job
branch
from
a08ce99 to
13b5dc9
Compare
Dyostiq
force-pushed
the
feature/MARXAN-305-pass-assets-to-run-job
branch
from
13b5dc9 to
929bf3a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Substitute this line for a meaningful title for your changes
Overview
Please write a description. If the PR is hard to understand, provide a quick explanation of the code.
Designs
Link to the related design prototypes (if applicable)
Testing instructions
Please explain how to test the PR: ID of a dataset, steps to reach the feature, etc.
Feature relevant tickets
Link to the related task manager tickets
Checklist before submitting
develop.deploying to staging/production, please add brief testing instructions
to the deploy checklist (
docs/deployment-checklist.md)