Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tiles): include project-id in wdpa queries #533

Merged
merged 6 commits into from
Sep 17, 2021
Merged

fix(tiles): include project-id in wdpa queries #533

merged 6 commits into from
Sep 17, 2021

Conversation

kgajowy
Copy link
Contributor

@kgajowy kgajowy commented Sep 15, 2021 •
edited
Loading

TODO:

  • finish removing unnecessary abstraction (for wdpa)
  • figure out best way to remove knowledge of areas from tiles module and not to pollute it with database fields arguments
  • wrap proper/verbose e2e spec (current one misses assertions)

@vercel
Copy link

vercel bot commented Sep 15, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

marxan – ./app

🔍 Inspect: https://vercel.com/vizzuality1/marxan/4C7GjeMbjcaKXYB8YJeYYjuSn6At
✅ Preview: https://marxan-git-fix-marxan-165-marxan-595-conside-334e47-vizzuality1.vercel.app

marxan-storybook – ./app

🔍 Inspect: https://vercel.com/vizzuality1/marxan-storybook/A3BvTC5KHpdGxz7imQ164diyqPUi
✅ Preview: https://marxan-storybook-git-fix-marxan-165-marxan-5-0b79cc-vizzuality1.vercel.app

@kgajowy kgajowy force-pushed the fix/MARXAN-165-MARXAN-595-consider-project-id-for-wdpa-tiles branch from 56c165d to 3214c38 Compare September 16, 2021 06:26
@kgajowy kgajowy marked this pull request as ready for review September 16, 2021 06:27
@kgajowy kgajowy requested review from aagm and hotzevzl September 16, 2021 06:27
@kgajowy kgajowy force-pushed the fix/MARXAN-165-MARXAN-595-consider-project-id-for-wdpa-tiles branch from 3214c38 to 1a52b0f Compare September 16, 2021 06:48
@kgajowy kgajowy force-pushed the fix/MARXAN-165-MARXAN-595-consider-project-id-for-wdpa-tiles branch from 2ab2fe6 to 1906d7b Compare September 17, 2021 07:14
@kgajowy kgajowy merged commit d9361ee into develop Sep 17, 2021
@kgajowy kgajowy deleted the fix/MARXAN-165-MARXAN-595-consider-project-id-for-wdpa-tiles branch September 17, 2021 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hotzevzl hotzevzl hotzevzl approved these changes

@aagm aagm Awaiting requested review from aagm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kgajowy @hotzevzl @aagm