[MARXAN-791] fix missing constraint leading to updating of rows that don't belong to the scenario being processed #548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this constraint, all rows (of any scenarios in any project) would be overwritten. For rows of the scenario being processed, the value of `protected_area` would be set to the correct value; for all other rows (other scenarios in any project), `protected_area` would be silently set to null as there is no data coming in via the CTE for rows that don't belong to the scenario being processed.
|
This pull request is being automatically deployed with Vercel (learn more). marxan – ./app🔍 Inspect: https://vercel.com/vizzuality1/marxan/9niHTetATtcEDuANKeGMeriedJE8 marxan-storybook – ./app🔍 Inspect: https://vercel.com/vizzuality1/marxan-storybook/BEQUTRL6jLGnCziRnHaFGjkEFtEJ |
hotzevzl
deleted the
fix/api/MARXAN-791_scenario-protected-area-calculation-is-reset
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this constraint, all rows (of any scenarios in any project) would be overwritten.
For rows of the scenario being processed, the value of
protected_areawould be set to the correct value; for all other rows (other scenarios in any project),protected_areawould be silently set to null as there is no data coming in via the CTE for rows that don't belong to the scenario being processed.https://vizzuality.atlassian.net/browse/MARXAN-791
I still need to check whether all tiles now include the
percentageProtecteddata, which should not have happened in any case at least for the scenario I was actively working on while triaging this issue.