-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MARXAN-235] password recovery #574
Conversation
This pull request is being automatically deployed with Vercel (learn more). marxan – ./app🔍 Inspect: https://vercel.com/vizzuality1/marxan/A1a2RRksq5QVSvEHuiVFhGfeajQk marxan-storybook – ./app🔍 Inspect: https://vercel.com/vizzuality1/marxan-storybook/4mEDXaTDskBookaaH46n1KpyuDvq |
0ec49ba
to
a873d1e
Compare
a873d1e
to
d0f73c9
Compare
d0f73c9
to
6689373
Compare
api/apps/api/src/modules/authentication/password-recovery/mailer.ts
Outdated
Show resolved
Hide resolved
api/apps/api/src/modules/authentication/password-recovery/password-recovery-token.api.entity.ts
Show resolved
Hide resolved
api/apps/api/src/modules/authentication/password-recovery/password-recovery.controller.ts
Outdated
Show resolved
Hide resolved
api/apps/api/src/modules/authentication/password-recovery/password-recovery.controller.ts
Show resolved
Hide resolved
api/apps/api/src/modules/authentication/password-recovery/password-recovery.controller.ts
Show resolved
Hide resolved
private isTokenExpired(currentDate: Date, token: Token) { | ||
return currentDate >= token.expiredAt; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think about letting Token
being able to know on its own if is expired?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought about that, and I can do this, but it has no significant impact as there's a single-use case, so it would be only a stylish refactor.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
up to you! feel free to close.
api/apps/api/src/modules/authentication/password-recovery/recovery-token.repository.ts
Show resolved
Hide resolved
api/apps/api/src/modules/authentication/password-recovery/token.factory.ts
Show resolved
Hide resolved
b839892
to
987ce79
Compare
Substitute this line for a meaningful title for your changes
Overview
Please write a description. If the PR is hard to understand, provide a quick explanation of the code.
Designs
Link to the related design prototypes (if applicable)
Testing instructions
Please explain how to test the PR: ID of a dataset, steps to reach the feature, etc.
Feature relevant tickets
Link to the related task manager tickets
Checklist before submitting
develop
.deploying to staging/production, please add brief testing instructions
to the deploy checklist (
docs/deployment-checklist.md
)