Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add brief for user workflow: adding users to projects/scenarios [MARXAN-1124] #770

Merged
merged 4 commits into from
Feb 14, 2022
Merged

add brief for user workflow: adding users to projects/scenarios [MARXAN-1124] #770

merged 4 commits into from
Feb 14, 2022

Conversation

hotzevzl
Copy link
Member

@vercel
Copy link

vercel bot commented Jan 19, 2022 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

marxan – ./app

🔍 Inspect: https://vercel.com/vizzuality1/marxan/Dw9wLCZstLZYSBYkATXZVGk3WydE
✅ Preview: https://marxan-git-docs-marxan-1124adding-users-with-roles-vizzuality1.vercel.app

marxan-storybook – ./app

🔍 Inspect: https://vercel.com/vizzuality1/marxan-storybook/ELCoAdYqcEKEDKyoL65msySfimJc
✅ Preview: https://marxan-storybook-git-docs-marxan-1124adding-e3e90f-vizzuality1.vercel.app

@hotzevzl hotzevzl force-pushed the docs/MARXAN-1124_adding-users-with-roles branch from d8306b6 to b714a0a Compare January 20, 2022 10:28
@hotzevzl hotzevzl force-pushed the docs/MARXAN-1124_adding-users-with-roles branch from b714a0a to dc75f49 Compare February 9, 2022 15:23
@hotzevzl hotzevzl force-pushed the docs/MARXAN-1124_adding-users-with-roles branch from dc75f49 to 75fb71d Compare February 9, 2022 15:24
@hotzevzl hotzevzl requested a review from dhakelila February 9, 2022 15:24
@hotzevzl
Copy link
Member Author

hotzevzl commented Feb 9, 2022

@dhakelila would you mind having a quick look at the small bit of product documentation added in this PR? I had written up your summary (IIRC) and added some technical hints to document assumptions behind the feature as designed, so it should be already familiar, but I'd appreciate a cross-check if you can. thanks!

@hotzevzl hotzevzl force-pushed the docs/MARXAN-1124_adding-users-with-roles branch from 75fb71d to 8bc6eb4 Compare February 9, 2022 15:37
dhakelila
dhakelila reviewed Feb 10, 2022
View reviewed changes
Copy link
Collaborator

@dhakelila dhakelila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Left a couple of little comments.
I'm using the users doc as reference to remember the roles/functionalities we had on mind
https://docs.google.com/document/d/16x4wQYTKov0JkO1ue6iQzJ3-RXpdgQ38ygGJWW86Zo0/edit#heading=h.uldt4yvqzw2o

@hotzevzl hotzevzl force-pushed the docs/MARXAN-1124_adding-users-with-roles branch from 8bc6eb4 to 836f84d Compare February 14, 2022 15:53
@hotzevzl
Copy link
Member Author

@dhakelila thank you - I have addressed all the comments and there were no concerns raised when we discussed this today with TNC, so I'm going to merge this

@hotzevzl hotzevzl merged commit de87058 into develop Feb 14, 2022
@hotzevzl hotzevzl deleted the docs/MARXAN-1124_adding-users-with-roles branch February 14, 2022 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhakelila dhakelila dhakelila left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hotzevzl @dhakelila