Feat/archive reader adapter #824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aciddaute
requested review from
hotzevzl,
AaronPerezPerez and
angelhigueraacid
|
This pull request is being automatically deployed with Vercel (learn more). marxan – ./app🔍 Inspect: https://vercel.com/vizzuality1/marxan/HrmVyM2vsBqMhwhHDdQzUryBQECA marxan-storybook – ./app🔍 Inspect: https://vercel.com/vizzuality1/marxan-storybook/9T43BD3gPQgfruyE3dmLNGqNWw3o |
aciddaute
force-pushed
the
feat/archive-reader-adapter
branch
from
5e8b0c1 to
f9be675
Compare
| l2: string | null; | ||
| puGridShape: PlanningUnitGridShape; | ||
| planningUnitAreakm2: number; | ||
| interface QueryResult { |
AaronPerezPerez
approved these changes
Feb 15, 2022
rubvalave
pushed a commit
that referenced
this pull request
Feb 16, 2022
* feat: fake archive reader adapter * feat: initial archive reader implementation * fix: typo and error handling * feat: added clone pieces data * ref: clone pieces relative paths * feat: import resource pieces * fix: export resource pieces adapter * fix: export resource pieces adapter * fix: removes testing controller * ref: zip file extractor ResourceId constructor validation * fix: ResourceKind validation in archive-reader adapter * fix: import resource pieces adapter * fix: wrong import Co-authored-by: Ángel Higuera Vaquero <angelhiguera@acidtango.com>
rubvalave
pushed a commit
that referenced
this pull request
Feb 16, 2022
* feat: fake archive reader adapter * feat: initial archive reader implementation * fix: typo and error handling * feat: added clone pieces data * ref: clone pieces relative paths * feat: import resource pieces * fix: export resource pieces adapter * fix: export resource pieces adapter * fix: removes testing controller * ref: zip file extractor ResourceId constructor validation * fix: ResourceKind validation in archive-reader adapter * fix: import resource pieces adapter * fix: wrong import Co-authored-by: Ángel Higuera Vaquero <angelhiguera@acidtango.com>
rubvalave
pushed a commit
that referenced
this pull request
Feb 16, 2022
* feat: fake archive reader adapter * feat: initial archive reader implementation * fix: typo and error handling * feat: added clone pieces data * ref: clone pieces relative paths * feat: import resource pieces * fix: export resource pieces adapter * fix: export resource pieces adapter * fix: removes testing controller * ref: zip file extractor ResourceId constructor validation * fix: ResourceKind validation in archive-reader adapter * fix: import resource pieces adapter * fix: wrong import Co-authored-by: Ángel Higuera Vaquero <angelhiguera@acidtango.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
ArchiveReaderadapter implementation and refactorsResourcePiecesadapters