MARXAN-1380-unpublish-public-project

[rubvalave]

-Adds endpoint for project_owners to unpublish a public project.
-Adds conditions to when clearing a project from under moderation to be able to outright unpublish the project straightaway.
-Adds tests for the new endpoint and changes in the workflow.

Depends on #896 being closed beforehand.

[vercel]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

marxan – ./app

🔍 Inspect: https://vercel.com/vizzuality1/marxan/4Y8LRTLXbmqvfWQVPm3VFwkqvqMd
✅ Preview: https://marxan-git-marxan-1380-unpublish-endpoint-pr-c22c48-vizzuality1.vercel.app

marxan-storybook – ./app

🔍 Inspect: https://vercel.com/vizzuality1/marxan-storybook/HvuL5FDQyZxJAuRUjDDWRfx2zXQX
✅ Preview: https://marxan-storybook-git-marxan-1380-unpublish-e-9b16b6-vizzuality1.vercel.app

[hotzevzl]

thanks! IIRC you asked for naming suggestions on a different PR but I ended up suggesting a couple of naming changes here too... feel free to decide.

all the rest looks good!

[hotzevzl]

while we are revisiting this, let's make the name more explicit

Suggested change

	if (!id || !(await this.usersService.isPlatformAdmin(id))) {
	if (!userId || !(await this.usersService.isPlatformAdmin(userId))) {

[hotzevzl]

what about

Suggested change

	withUnpublish?: boolean,
	alsoUnpublish?: boolean,

[hotzevzl]

mh, this is quite down to preference, but I suggest to treat this as a kind-of-RPC-thingy-even-if-behind-the-scenes-we-are-deleting-a-resource and use POST instead

Suggested change

	@Delete(':id/unpublish')
	@Post(':id/unpublish')