pass cookie through as proper cookie [MARXAN-1402] #932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). marxan – ./app🔍 Inspect: https://vercel.com/vizzuality1/marxan/CTSbqjGkrByMAhYFG6NX5WfhHu9s |
rubvalave
approved these changes
Mar 25, 2022
hotzevzl
deleted the
fix/api/MARXAN-1402_pass-cookie-through-as-proper-cookie
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://vizzuality.atlassian.net/browse/MARXAN-1402
The initial implementation did extract the next auth session token from the request
Cookie(as it said on the tin), but in fact we need this in a cookie-like format in order to pass this on to the webshot service.So this change does that - we get the relevant cookie from the request, and we return this as a new cookie ready to be consumed by the webshot microservice (via the API webshot NestJS service).
This could be arguably be done differently, by keeping just the session token in flight until the webshot microservice, and put form that into a cookie shape in the webshot microservice itself. I think this change is good enough.