Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/png image complains webshot ci build #957

Merged
merged 3 commits into from
Apr 5, 2022

Conversation

rubvalave
Copy link
Contributor

-Adds CI for webshot service build process.
-Fix minor TS complaints in png-image generation.
-Minor fixes.

@rubvalave rubvalave requested a review from hotzevzl April 5, 2022 15:23
@rubvalave rubvalave self-assigned this Apr 5, 2022
@vercel
Copy link

vercel bot commented Apr 5, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

marxan – ./app

🔍 Inspect: https://vercel.com/vizzuality1/marxan/5iXZDjuW8B6bLkzgDfwLZm4cEahA
✅ Preview: https://marxan-git-fix-png-image-complains-webshot-ci-build-vizzuality1.vercel.app

marxan-storybook – ./app

🔍 Inspect: https://vercel.com/vizzuality1/marxan-storybook/3MiHNbZQCCGJSjXErMWDn483k7KX
✅ Preview: https://marxan-storybook-git-fix-png-image-complains-556551-vizzuality1.vercel.app

Copy link
Member

@hotzevzl hotzevzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other than the 1000ms race timeout, all good - thanks for your patience through my wavy "guidance" for this PR 😬

@rubvalave rubvalave merged commit c20a823 into develop Apr 5, 2022
@rubvalave rubvalave deleted the fix/png-image-complains-webshot-ci-build branch April 5, 2022 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants