Enhance UI components and navigation #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
atrincas
force-pushed
the
TBCCT-189-fe-design-review
branch
from
a3b5076 to
ec3eb79
Compare
andresgnlez
reviewed
Dec 18, 2024
Comment on lines
+2
to
+21
| /** Controls whether users can edit project details and settings in: | ||
| * - /projects/custom-project/details | ||
| * - /projects/custom-project/summary | ||
| */ | ||
| "edit-project": false, | ||
|
|
||
| /** Controls the visibility and sharing functionality in: | ||
| * - /profile | ||
| */ | ||
| "share-information": false, | ||
| /** Controls the project comparison functionality in: | ||
| * - /overview/project-details (scorecard ratings and cost estimates comparison) | ||
| */ | ||
| "project-comparison": false, | ||
| /** Controls the actions dropdown functionality in: | ||
| * - /my-projects table | ||
| */ | ||
| "update-selection": false, | ||
| /** Controls the visibility of the methodology page */ | ||
| "methodology-page": false, |
andresgnlez
reviewed
Dec 18, 2024
andresgnlez
reviewed
Dec 19, 2024
client/tailwind.config.ts
Outdated
Comment on lines
98
to
101
| "ramps-green": "#A4B591", | ||
| "ramps-yellow": "#F5EBB8", | ||
| "ramps-red": "#F7BA93", |
There was a problem hiding this comment.
We could have gone for ramps: { green: '#...', yellow: '#...', } as well 👍🏻
andresgnlez
reviewed
Dec 19, 2024
| @@ -218,15 +218,15 @@ export default function ToolbarProjectsTable() { | |||
| Each metric can go from a scale from low to high: | |||
| </p> | |||
| <div className="!mt-4 grid grid-cols-3 gap-2 text-center"> | |||
| <div className="height[fit-content] rounded-md bg-low p-2 text-sky-blue-950"> | |||
| <div className="height[fit-content] rounded-md bg-ramps-red p-2 text-sky-blue-950"> | |||
There was a problem hiding this comment.
Please, replace height[fit-content] with h-fit.
atrincas
force-pushed
the
TBCCT-189-fe-design-review
branch
from
f737a1c to
2721ef2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhance UI components and navigation
FE - Design review