Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: updated default values custom project form + refactor form tables #262

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

atrincas
Copy link
Collaborator

@atrincas atrincas commented Jan 30, 2025

Form Table Refactoring and Default Values

  1. Table Component Refactoring

    • Extracted common table logic into a reusable FormTable component
    • Reduced code duplication across multiple form sections (assumptions, capex, opex, other)
  2. Default Form Values

    • Added centralized default values in constants.ts
    • Updated form initialization to use consistent defaults
    • Added default value for project specific sequestration rate
  3. Minor Improvements

    • Updated number formatting to remove decimal places in table cells

Jira

Copy link

vercel bot commented Jan 30, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tnc-blue-carbon-cost-tool-ghps ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 30, 2025 7:28am

@atrincas atrincas requested a review from agnlez January 30, 2025 07:28
@agnlez
Copy link
Member

agnlez commented Jan 30, 2025

@atrincas while you are refactoring this zone, can you please take a look at the column alignment through different tables?
image

Ideally, the columns should be aligned vertically and the input field should have the same width always.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants