Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nim CI failure: nimgame2\utils.nim(169, 31) Error: type mismatch: got <ptr RWops, ptr char, csize, int literal(1000)> #40

Closed
timotheecour opened this issue Mar 13, 2020 · 4 comments

Comments

@timotheecour
Copy link

timotheecour commented Mar 13, 2020

see nim-lang/Nim#13550 (comment)

EDIT: see PR #41 that fixes it

timotheecour added a commit to timotheecour/nimgame2 that referenced this issue Mar 13, 2020
@timotheecour timotheecour mentioned this issue Mar 13, 2020
@Vladar4
Copy link
Owner

Vladar4 commented Mar 13, 2020

I believe it's already fixed in devel: 8ea89ba#diff-cdb07207a519ef4c7003f883c113dc5bL241
Please, confirm.

@timotheecour
Copy link
Author

timotheecour commented Mar 13, 2020

devel doesn't help; nim CI clones the main branch (which is set to master in your repo)
so either important_packages.nim needs to be updated, or your repo's master needs to be updated;
WDYT?

Note: IMO it's possible to have nim CI test both your devel AND master branch; but support for that feature in important_packages may need to be added for that to work

@Vladar4
Copy link
Owner

Vladar4 commented Mar 13, 2020

Fair enough.
I've applied this commit into the master branch: 4f36797
Please, let me know if it solves the issue.

@timotheecour
Copy link
Author

should be but haven't verified, closing for now, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants