Min roll #33
Merged
Min roll #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
February 11, 2021 11:55
test: Added tests for minimum dice roll flag. While working on the minimum dice roll flag, I found that there are a few tests that do not have properly set minimums. Worse yet, the dice roller does not appear to handle <float>d<int> cases well it seems and is giving values lower than the minimum that it should.
test: Added further tests to ensure float num_dice values work. We had an issue where, if num_dice was given as a float, we were making changes to all dice rolls instead of the last one that we needed to make which was causing our rolls to not have the correct percentage chances. This has been corrected and the fractional handler will only be applied at the end after all other rolls have been made.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: Added the ability to specify that the dice should return their minimum possible value.
fix: Fixed issue with percentage chances for dice where the number was supplied as a float.
test: Added further testing to ensure minimum flag works and the fix for float num_dice was corrected.
Closes issues #15, #32