Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More song language options #1441

Closed
FinnRG opened this issue May 20, 2023 · 3 comments · Fixed by #1459
Closed

More song language options #1441

FinnRG opened this issue May 20, 2023 · 3 comments · Fixed by #1459
Assignees
Labels
complexity: low Around 1 day of work content: lyrics Song lyrics frontend Presentation layer (visible to user)

Comments

@FinnRG
Copy link
Member

FinnRG commented May 20, 2023

Based off #1428.

We are currently only displaying a subset of the ISO 639-1/639-2 language codes for lyric languages. This should be expanded to allow a removal of all language tags on VocaDb after the implementation of #1408. We also need to continue supporting the current culture codes for backwards compatibility reasons.

After reviewing our current language tags I think that using the glottolog codes going forward is best. The glottolog codes include regional dialects, some fictional/constructed languages and indigenous languages. The large number of languages can also cause confusion for users, so these less common languages should only appear after the user clicks a "More Languages" button.

@FinnRG FinnRG added complexity: low Around 1 day of work frontend Presentation layer (visible to user) content: lyrics Song lyrics labels May 20, 2023
@FinnRG FinnRG self-assigned this May 20, 2023
@FinnRG FinnRG moved this to In Progress in Frontend overhaul May 20, 2023
@szc126
Copy link
Collaborator

szc126 commented May 20, 2023

Personally I think ISO is still better, due to the standard nature and common usage. I've never seen glottolog in the wild except for on Wikipedia, and I also reckon that the granularity would get quickly confusing, and probably unnecessary.

@FinnRG
Copy link
Member Author

FinnRG commented May 21, 2023

  1. I also prefer ISO codes. We will also have to support ISO codes in the future because we need to be backwards compatible. There are however some languages and dialects which aren't covered by ISO codes. The most popular example would be brazilian portuguese with around 118 songs.
  2. I really want to avoid having some languages covered by the new language field (Song entry: New field for language #1408) and some by tags.

Maybe the best solution is to use ISO 639-3 codes per default, which should cover the majority of use cases and add glottolog codes per request. This is relatively easy because the backend only stores the culture codes as strings and doesn't validate them.

@szc126
Copy link
Collaborator

szc126 commented May 21, 2023

  1. What about modifiers like pt-BR? That's a pretty common extension of the ISO codes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
complexity: low Around 1 day of work content: lyrics Song lyrics frontend Presentation layer (visible to user)
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants