-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Song entry: New field for language #1408
Comments
I think this is a good idea. Here are some stats:
Thus, deriving the language of a song from the original lyrics only gives us about 1/3 of all songs, so a new language field should provide valuable additional data. But there are still some open questions.
|
A: I think the lyrics language should be automatically added into the language field if they are available. Same should be done vice versa: When entering the lyrics tab, the original language will already be chosen and can not be changed (greyed out), only the lyrics can be added/edited.
A: Maybe there could be suggestions displayed or nothing at all. I am not sure what is the best option here.
A: Note that lyrics (in the lyrics tab) are already inherited from the original entry automatically. If both, the language and the lyrics are connected, it would make sense to follow that pattern. Some cover songs etc. can have changed language. Perhaps it could be connected to the tag "changed language" in a way that the lyrics/languages are not copied. |
Agreeing with @andreoda's points.
Having a warning seems like the safest choice. There can be some edge cases where it doesn't make sense to disable the field. There are a few languages that currently can not be added as "lyrics": I think it'd make sense to add these instead of reverting to "other/unknown". How to handle bi/tri-lingual songs (where the language share is equal) is one open question.
Safe for maybe 99% of the songs. Although 1% is around ~4 000 entries which is a bit too much. |
Are we going to be making it so that we can set the language of artist entries, too? Or would we continue to use tags for them? |
The scope of this issue only includes songs. Is your suggestion covered by #1409?
I agree. I've created #1428 to track this particular issue. |
Is your feature request related to a problem? Please describe.
A song's language can be determined by the (original) lyrics added to the song entry but many entries do not have lyrics added to them (Either because they are not added yet or they couldn't be found).
Another way of setting a song's language is by adding language tags but that should be avoided in a better system.
Describe the solution you'd like.
There could be a field in the song entry where users could set a song's (main) language.
It could be displayed under or above the "Duration" field and could have the same drop-down menu as given in the lyrics options.
Related issues:
The text was updated successfully, but these errors were encountered: