Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Song entry: New field for language #1408

Closed
andreoda opened this issue May 8, 2023 · 6 comments · Fixed by #1467
Closed

Song entry: New field for language #1408

andreoda opened this issue May 8, 2023 · 6 comments · Fixed by #1467
Labels
adding/editing entries Adding/Editing entries (artists, songs, albums, tags, song lists, events) content: lyrics Song lyrics content: songs Song entries feedback-wanted Feedback and further discussion needed (open questions) UX/usability UX (User Experience): Methods for improving the usablitiy

Comments

@andreoda
Copy link
Member

andreoda commented May 8, 2023

Is your feature request related to a problem? Please describe.

A song's language can be determined by the (original) lyrics added to the song entry but many entries do not have lyrics added to them (Either because they are not added yet or they couldn't be found).
Another way of setting a song's language is by adding language tags but that should be avoided in a better system.

Describe the solution you'd like.

There could be a field in the song entry where users could set a song's (main) language.
It could be displayed under or above the "Duration" field and could have the same drop-down menu as given in the lyrics options.


Related issues:

@andreoda andreoda added content: lyrics Song lyrics content: songs Song entries adding/editing entries Adding/Editing entries (artists, songs, albums, tags, song lists, events) UX/usability UX (User Experience): Methods for improving the usablitiy labels May 8, 2023
@FinnRG
Copy link
Member

FinnRG commented May 15, 2023

I think this is a good idea. Here are some stats:

  • English: 5100 songs with English lyrics / 12500 songs tagged with "English"
  • Spanish: 300 songs with any lyrics / 1100 songs tagged with "Spanish"
  • French: 100 songs with any lyrics / 350 songs tagged with "French"

Thus, deriving the language of a song from the original lyrics only gives us about 1/3 of all songs, so a new language field should provide valuable additional data.

But there are still some open questions.

  1. What if the user selects a different language for the original lyrics and the new language field? Should we just give a warning or reject the entry? Should the language field be disabled if there are original lyrics?
  2. Should we infer the language for certain voicebanks?
  3. Should we automatically add the language for some derived songs? And if so, what types of derived songs imply unmodified language?

@andreoda
Copy link
Member Author

andreoda commented May 15, 2023

  1. What if the user selects a different language for the original lyrics and the new language field? Should we just give a warning or reject the entry? Should the language field be disabled if there are original lyrics?

A: I think the lyrics language should be automatically added into the language field if they are available. Same should be done vice versa: When entering the lyrics tab, the original language will already be chosen and can not be changed (greyed out), only the lyrics can be added/edited.
I mean, the lyrics and the language field should be somehow connected.

  1. Should we infer the language for certain voicebanks?

A: Maybe there could be suggestions displayed or nothing at all. I am not sure what is the best option here.

  1. Should we automatically add the language for some derived songs? And if so, what types of derived songs imply unmodified language?

A: Note that lyrics (in the lyrics tab) are already inherited from the original entry automatically. If both, the language and the lyrics are connected, it would make sense to follow that pattern.

Some cover songs etc. can have changed language. Perhaps it could be connected to the tag "changed language" in a way that the lyrics/languages are not copied.

@andreoda andreoda added the feedback-wanted Feedback and further discussion needed (open questions) label May 15, 2023
@Shiroizu
Copy link
Member

Shiroizu commented May 15, 2023

Agreeing with @andreoda's points.

  1. What if the user selects a different language for the original lyrics and the new language field? Should we just give a warning or reject the entry? Should the language field be disabled if there are original lyrics?

Having a warning seems like the safest choice. There can be some edge cases where it doesn't make sense to disable the field.

There are a few languages that currently can not be added as "lyrics":

I think it'd make sense to add these instead of reverting to "other/unknown".

How to handle bi/tri-lingual songs (where the language share is equal) is one open question.

  1. Should we infer the language for certain voicebanks?

Safe for maybe 99% of the songs. Although 1% is around ~4 000 entries which is a bit too much.

@andreoda
Copy link
Member Author

andreoda commented May 15, 2023

One more addition:

These are the language tags we currently have (for reference):
grafik

These are the lyrics tags we currently have (for reference):
grafik

@CatgirlFrostmoon
Copy link

Are we going to be making it so that we can set the language of artist entries, too? Or would we continue to use tags for them?
And yeah, I'd like to second Shiroizu's note about how we handle multilingual entries; a song like "Dancer in the Dark" utilizes both English and Japanese in relatively equal measure, so trying to label it as only "Japanese" or only "English" is something of a misnomer.

@FinnRG
Copy link
Member

FinnRG commented May 17, 2023

Are we going to be making it so that we can set the language of artist entries, too? Or would we continue to use tags for them?

The scope of this issue only includes songs. Is your suggestion covered by #1409?

And yeah, I'd like to second Shiroizu's note about how we handle multilingual entries; a song like "Dancer in the Dark" utilizes both English and Japanese in relatively equal measure, so trying to label it as only "Japanese" or only "English" is something of a misnomer.

I agree. I've created #1428 to track this particular issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
adding/editing entries Adding/Editing entries (artists, songs, albums, tags, song lists, events) content: lyrics Song lyrics content: songs Song entries feedback-wanted Feedback and further discussion needed (open questions) UX/usability UX (User Experience): Methods for improving the usablitiy
Development

Successfully merging a pull request may close this issue.

4 participants