Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Songs: Changing song language does not affect lyrics language #1695

Open
2 of 7 tasks
szc126 opened this issue Mar 2, 2024 · 1 comment
Open
2 of 7 tasks

Songs: Changing song language does not affect lyrics language #1695

szc126 opened this issue Mar 2, 2024 · 1 comment
Labels
adding/editing entries Adding/Editing entries (artists, songs, albums, tags, song lists, events) bug/error Bugs and errors (timeout) complexity: unknown Unknown days of work content: entry-languages Entry languages data-field content: lyrics Song lyrics content: songs Song entries entry-activity Entry activities/changes to entries, Entry reports priority: low Issues/Tasks that are not so important

Comments

@szc126
Copy link
Collaborator

szc126 commented Mar 2, 2024

Website (required)

VocaDB

Describe the bug (required)

Changing song language (Basic info > Language) does not affect lyrics language (Lyrics > Original > Language).

Examples:
https://vocadb.net/Song/ViewVersion/1919121 (three languages)
https://vocadb.net/Song/ViewVersion/1919091
https://vocadb.net/Song/ViewVersion/1919090
https://vocadb.net/Song/ViewVersion/1919089
https://vocadb.net/Song/ViewVersion/1919088

To Reproduce (optional)

Steps to reproduce the behavior:

  1. Go to the edit page of a song entry that has lyrics.
  2. Change the song language under Basic info.
  3. Save.
  4. See error (the lyrics language has not changed, and the song will still show up in a search by language, under the unchanged lyrics' language)

Expected behavior (optional)

Lyrics language follows song language. The opposite (song language follows lyrics language) already happens instantly in the editor.

Desktop (optional)

  • OS: Linux
  • Browser: Firefox 122.0.1

Checklist (required)

Fill out the checklist. Use strikethroughs or leave fields empty if you don't know or are unable to check/test.

  • Searched VocaDB/vocadb for duplicate issues.
  • Tested on the beta site.
  • Tested on different browsers (e.g. Firefox, Chrome, Safari, Edge).
  • Checked in private mode.
  • Cleared browser cache and cookies.
  • Checked the DevTools console.
  • Checked the syslog (mods+ only).
@FinnRG
Copy link
Member

FinnRG commented Mar 2, 2024

This was intentional at the time (#1408 (comment)) to mimic the frontend fallback, but I guess we can implement a warning or sync them automatically.

@andreoda andreoda added text Text/Characters display (Markup language: Markdown) content: lyrics Song lyrics content: songs Song entries bug/error Bugs and errors (timeout) and removed text Text/Characters display (Markup language: Markdown) labels Mar 4, 2024
@andreoda andreoda added priority: low Issues/Tasks that are not so important content: entry-languages Entry languages data-field adding/editing entries Adding/Editing entries (artists, songs, albums, tags, song lists, events) entry-activity Entry activities/changes to entries, Entry reports complexity: unknown Unknown days of work labels Mar 6, 2024
@andreoda andreoda changed the title Changing song language does not affect lyrics language Songs: Changing song language does not affect lyrics language Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
adding/editing entries Adding/Editing entries (artists, songs, albums, tags, song lists, events) bug/error Bugs and errors (timeout) complexity: unknown Unknown days of work content: entry-languages Entry languages data-field content: lyrics Song lyrics content: songs Song entries entry-activity Entry activities/changes to entries, Entry reports priority: low Issues/Tasks that are not so important
Projects
Development

No branches or pull requests

3 participants