Implement of spanish version #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VojtaStruhar
requested changes
Jun 10, 2024
There was a problem hiding this comment.
These vscode settings are personal preference. I'd rather it not be in the repo
| <PageLayout title="Plantilla de reseñas de steam"> | ||
| <header class="bg-slate-700 text-white py-2 flex flex-col items-center"> | ||
| <h1>{"---{ Plantilla para reseñas }---"}</h1> | ||
| <a href="/steam-review-template/en/" class="mt-0 text-white">Sitio en ingles</a> |
There was a problem hiding this comment.
Instead of this subtitle line, can we maybe do emojis in the corner? Something more subtle 🇪🇸 🇬🇧
Comment on lines
+86
to
+152
| <script> | ||
| var data = {}; | ||
| import config_json from "../../review_templates/template_en.json"; | ||
|
|
||
| function showOutput() { | ||
| copyButton?.style.setProperty("display", "block"); | ||
| let output = document.getElementById("output"); | ||
| if (output) { | ||
| output.innerHTML = ""; | ||
| config_json.categories.forEach((category) => { | ||
| output.innerHTML += `\n---{ ${category.title} }---\n`; | ||
| category.options.forEach((item) => { | ||
| if ( | ||
| category.type === "check" && | ||
| data[category.title].includes(item) | ||
| ) { | ||
| output.innerHTML += `☑ ${item}\n`; | ||
| } else if (data[category.title] === item) { | ||
| output.innerHTML += `☑ ${item}\n`; | ||
| } else { | ||
| output.innerHTML += `☐ ${item}\n`; | ||
| } | ||
| }); | ||
| }); | ||
|
|
||
| output.innerHTML += `\n`; | ||
| output.innerHTML += `---{ Author }---\n`; | ||
| output.innerHTML += `☑ https://vojtastruhar.github.io/steam-review-template \n`; | ||
| } | ||
| } | ||
|
|
||
| let outputButton = document.getElementById("output-button"); | ||
| if (outputButton) { | ||
| outputButton.addEventListener("click", showOutput); | ||
| } | ||
| let copyButton = document.getElementById("copy-output"); | ||
| if (copyButton) { | ||
| copyButton.addEventListener("click", () => { | ||
| navigator.clipboard.writeText( | ||
| document.getElementById("output").innerText | ||
| ); | ||
| }); | ||
| } | ||
| copyButton?.style.setProperty("display", "none"); | ||
|
|
||
| [...document.getElementsByTagName("input")].forEach((input) => { | ||
| if (input.type == "checkbox") { | ||
| data[input.name] = []; | ||
| } | ||
| input.addEventListener("change", (event) => { | ||
| let target = event.target; | ||
| if (target) { | ||
| if (target.type == "checkbox") { | ||
| if (target.checked) { | ||
| data[target.name].push(target.value); | ||
| } else { | ||
| data[target.name] = data[target.name].filter( | ||
| (item) => item != target.value | ||
| ); | ||
| } | ||
| } else { | ||
| data[target.name] = target.value; | ||
| } | ||
| } | ||
| }); | ||
| }); | ||
| </script> |
There was a problem hiding this comment.
Now that we have more than 1 language, this can definitely be refactored. I'd say it's going to be a function in a separate .js file with a language argument? Can Astro do that?
| </fieldset> | ||
| </form> | ||
| )) | ||
| } |
There was a problem hiding this comment.
This logic doesn't care about what language it is. We should refactor it into a separate file, so that adding more languages is easier!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spanish version
I implemented the spanish version of the webpage only by separating in diferents lenguajes the index and making an specific template.json.
Also adding a link to redirect to each site.