Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add E2E tests #349

Merged
merged 2 commits into from
Nov 13, 2024
Merged

Add E2E tests #349

merged 2 commits into from
Nov 13, 2024

Conversation

vitPinchuk
Copy link
Contributor

Resolves: #342

@vitPinchuk vitPinchuk self-assigned this Nov 8, 2024
@vitPinchuk vitPinchuk marked this pull request as ready for review November 8, 2024 12:25
@codecov Codecov
Copy link

codecov bot commented Nov 8, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.67%. Comparing base (eea576c) to head (a37437c).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #349   +/-   ##
=======================================
  Coverage   98.67%   98.67%           
=======================================
  Files          58       58           
  Lines         832      832           
  Branches      132      138    +6     
=======================================
  Hits          821      821           
  Misses         11       11

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mikhail-vl mikhail-vl added the enhancement New feature or request label Nov 11, 2024
@mikhail-vl mikhail-vl added this to the Charts 6.6.0 milestone Nov 11, 2024
asimonok
asimonok approved these changes Nov 12, 2024
View reviewed changes
Copy link
Collaborator

@asimonok asimonok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mikhail-vl ready for review

mikhail-vl
mikhail-vl approved these changes Nov 13, 2024
View reviewed changes
Copy link
Member

@mikhail-vl mikhail-vl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mikhail-vl mikhail-vl merged commit 7b857e2 into main Nov 13, 2024
5 checks passed
@mikhail-vl mikhail-vl deleted the feat/e2e-update branch November 13, 2024 02:25
@mikhail-vl mikhail-vl modified the milestones: Charts 6.6.0, Charts 7.0.0 Dec 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikhail-vl mikhail-vl mikhail-vl approved these changes

@asimonok asimonok asimonok approved these changes

Assignees

@vitPinchuk vitPinchuk

Labels
enhancement New feature or request
Projects
Business Suite
Archived in project
Milestone
Charts 7.0.0
Development

Successfully merging this pull request may close these issues.

Add E2E tests
3 participants
@vitPinchuk @asimonok @mikhail-vl