Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Query and Data Source initial request #237

Merged
merged 5 commits into from
Aug 30, 2023
Merged

Conversation

mikhail-vl
Copy link
Member

@mikhail-vl mikhail-vl commented Aug 30, 2023

  1. Highlights changes for Query Initial request is not working.
  2. elements values are empty in the Custom Code when using Data Source and Query.
  3. Query does not refresh the form.

Configuration dashboards provisioned with example: http://localhost:3000/d/d185bf58-9e0a-4373-befa-3905a18af42e/configuration?orgId=1&var-device=device1

@mikhail-vl mikhail-vl added the enhancement New feature or request label Aug 30, 2023
@mikhail-vl mikhail-vl added this to the Version 3.2.0 milestone Aug 30, 2023
@mikhail-vl mikhail-vl assigned mikhail-vl and asimonok and unassigned mikhail-vl Aug 30, 2023
@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Patch coverage: 88.88% and project coverage change: -0.32% ⚠️

Comparison is base (fdffa0f) 97.79% compared to head (1f43e4d) 97.48%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #237      +/-   ##
==========================================
- Coverage   97.79%   97.48%   -0.32%     
==========================================
  Files          51       52       +1     
  Lines         861      874      +13     
  Branches      158      161       +3     
==========================================
+ Hits          842      852      +10     
- Misses          8       10       +2     
- Partials       11       12       +1     
Files Changed Coverage Δ
src/utils/grafana.ts 25.00% <25.00%> (ø)
src/components/FormPanel/FormPanel.tsx 93.54% <100.00%> (+0.17%) ⬆️
src/hooks/index.ts 100.00% <100.00%> (ø)
src/utils/form-element.ts 98.03% <100.00%> (+0.12%) ⬆️
src/utils/index.ts 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member Author

@mikhail-vl mikhail-vl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@mikhail-vl mikhail-vl merged commit 9d35851 into main Aug 30, 2023
4 of 6 checks passed
@mikhail-vl mikhail-vl deleted the feat/update-query branch August 30, 2023 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants