Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update custom code when switching the value editor from manual to JS #59

Merged
merged 3 commits into from
Feb 19, 2024
Merged

Update custom code when switching the value editor from manual to JS #59

merged 3 commits into from
Feb 19, 2024

Conversation

vitPinchuk
Copy link
Contributor

resolves: #55

@vitPinchuk vitPinchuk requested a review from asimonok February 19, 2024 11:40
@vitPinchuk vitPinchuk self-assigned this Feb 19, 2024
asimonok
asimonok approved these changes Feb 19, 2024
View reviewed changes
Copy link
Collaborator

@asimonok asimonok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mikhail-vl ready for review

@mikhail-vl mikhail-vl added the enhancement New feature or request label Feb 19, 2024
@mikhail-vl mikhail-vl added this to the Version 3.1.0 milestone Feb 19, 2024
@mikhail-vl mikhail-vl changed the title Fix: Console Error when switching the value editor from manual to JS Update custom code when switching the value editor from manual to JS Feb 19, 2024
@codecov Codecov
Copy link

codecov bot commented Feb 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8e80fd9) 99.32% compared to head (0dc9c92) 97.33%.
Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #59      +/-   ##
==========================================
- Coverage   99.32%   97.33%   -2.00%     
==========================================
  Files          30       32       +2     
  Lines         295      412     +117     
  Branches       36       60      +24     
==========================================
+ Hits          293      401     +108     
- Misses          0       11      +11     
+ Partials        2        0       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mikhail-vl
mikhail-vl approved these changes Feb 19, 2024
View reviewed changes
Copy link
Member

@mikhail-vl mikhail-vl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I fixed Token to CodeCov.

@mikhail-vl mikhail-vl merged commit 9470706 into main Feb 19, 2024
3 of 4 checks passed
@mikhail-vl mikhail-vl deleted the feat/console-error branch February 19, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asimonok asimonok asimonok approved these changes

@mikhail-vl mikhail-vl mikhail-vl approved these changes

Assignees

@vitPinchuk vitPinchuk

Labels
enhancement New feature or request
Projects
None yet
Milestone
Version 3.1.0
Development

Successfully merging this pull request may close these issues.

Console Error when switching the value editor from manual to JS
3 participants
@vitPinchuk @asimonok @mikhail-vl