Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Image URL to data links #122

Merged
merged 5 commits into from
Jun 26, 2024
Merged

Update Image URL to data links #122

merged 5 commits into from
Jun 26, 2024

Conversation

vitPinchuk
Copy link
Contributor

Resolve: #110

@vitPinchuk vitPinchuk self-assigned this Jun 25, 2024
@codecov Codecov
Copy link

codecov bot commented Jun 25, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (3d1c46a) to head (9624e23).

❗ Current head 9624e23 differs from pull request most recent head a7db1d0

Please upload reports for the commit a7db1d0 to get more accurate results.

Additional details and impacted files 
@@            Coverage Diff            @@
##              main      #122   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           19        20    +1     
  Lines          288       306   +18     
  Branches        95        99    +4     
=========================================
+ Hits           288       306   +18

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mikhail-vl mikhail-vl added the enhancement New feature or request label Jun 25, 2024
@mikhail-vl mikhail-vl added this to the Version 5.2.0 milestone Jun 25, 2024
@mikhail-vl
Copy link
Member

@vitPinchuk Please resolve conflicts

asimonok
asimonok approved these changes Jun 26, 2024
View reviewed changes
Copy link
Collaborator

@asimonok asimonok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mikhail-vl ready for review

mikhail-vl
mikhail-vl approved these changes Jun 26, 2024
View reviewed changes
Copy link
Member

@mikhail-vl mikhail-vl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mikhail-vl mikhail-vl merged commit f6ea324 into main Jun 26, 2024
3 checks passed
@mikhail-vl mikhail-vl deleted the feat/data-links branch June 26, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikhail-vl mikhail-vl mikhail-vl approved these changes

@asimonok asimonok asimonok approved these changes

Assignees

@vitPinchuk vitPinchuk

Labels
enhancement New feature or request
Projects
None yet
Milestone
Media 5.2.0
Development

Successfully merging this pull request may close these issues.

Update Image URL to data links
3 participants
@vitPinchuk @mikhail-vl @asimonok