Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add slideshow between mixed media #123

Merged
merged 10 commits into from
Jul 1, 2024
Merged

Add slideshow between mixed media #123

merged 10 commits into from
Jul 1, 2024

Conversation

vitPinchuk
Copy link
Contributor

Resolves: #109

@vitPinchuk vitPinchuk self-assigned this Jun 26, 2024
@codecov Codecov
Copy link

codecov bot commented Jun 26, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (f6ea324) to head (940389b).

❗ Current head 940389b differs from pull request most recent head 6da9c57

Please upload reports for the commit 6da9c57 to get more accurate results.

Additional details and impacted files 
@@            Coverage Diff            @@
##              main      #123   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           20        20           
  Lines          306       337   +31     
  Branches        99        92    -7     
=========================================
+ Hits           306       337   +31

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mikhail-vl mikhail-vl added the enhancement New feature or request label Jun 26, 2024
@mikhail-vl mikhail-vl added this to the Version 5.2.0 milestone Jun 26, 2024
mikhail-vl
mikhail-vl requested changes Jun 26, 2024
View reviewed changes
Copy link
Member

@mikhail-vl mikhail-vl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vitPinchuk Please resolve conflicts.

asimonok
asimonok approved these changes Jun 27, 2024
View reviewed changes
Copy link
Collaborator

@asimonok asimonok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mikhail-vl ready for review

mikhail-vl
mikhail-vl requested changes Jun 28, 2024
View reviewed changes
Copy link
Member

@mikhail-vl mikhail-vl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update sliderAutoPlayInfinity .

src/module.ts Outdated Show resolved Hide resolved
@vitPinchuk vitPinchuk requested a review from mikhail-vl June 28, 2024 05:47
mikhail-vl
mikhail-vl approved these changes Jul 1, 2024
View reviewed changes
Copy link
Member

@mikhail-vl mikhail-vl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@mikhail-vl mikhail-vl merged commit efe20ce into main Jul 1, 2024
3 checks passed
@mikhail-vl mikhail-vl deleted the feat/slideshow-added branch July 1, 2024 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikhail-vl mikhail-vl mikhail-vl approved these changes

@asimonok asimonok asimonok approved these changes

Assignees

@vitPinchuk vitPinchuk

Labels
enhancement New feature or request
Projects
None yet
Milestone
Media 5.2.0
Development

Successfully merging this pull request may close these issues.

Add slideshow between mixed media
3 participants
@vitPinchuk @asimonok @mikhail-vl