Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update adding new render media sources #137

Merged
merged 2 commits into from
Aug 16, 2024
Merged

Conversation

vitPinchuk
Copy link
Contributor

Resolves: #136

@vitPinchuk vitPinchuk self-assigned this Aug 15, 2024
Copy link

codecov bot commented Aug 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (b14b49c) to head (a5cac1e).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #137   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           26        26           
  Lines          455       455           
  Branches       134       134           
=========================================
  Hits           455       455           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mikhail-vl mikhail-vl added the enhancement New feature or request label Aug 15, 2024
@mikhail-vl mikhail-vl added this to the Media 6.1.0 milestone Aug 15, 2024
@mikhail-vl mikhail-vl requested a review from a team August 16, 2024 10:51
Copy link
Collaborator

@asimonok asimonok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mikhail-vl ready for review

@mikhail-vl mikhail-vl changed the title Fix: Render media source from initial Update adding new render media source Aug 16, 2024
@mikhail-vl mikhail-vl changed the title Update adding new render media source Update adding new render media sources Aug 16, 2024
Copy link
Member

@mikhail-vl mikhail-vl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mikhail-vl mikhail-vl merged commit dcdaa44 into main Aug 16, 2024
5 checks passed
@mikhail-vl mikhail-vl deleted the feat/render-media-source branch August 16, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Adding media source does not render
3 participants