Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CSS class for the Panel instead of a Row #272

Merged
merged 11 commits into from
Mar 6, 2024
Merged

Update CSS class for the Panel instead of a Row #272

merged 11 commits into from
Mar 6, 2024

Conversation

vitPinchuk
Copy link
Contributor

@vitPinchuk vitPinchuk commented Feb 23, 2024 •
edited
Loading

Resolve #258

  1. Added suport for container through & {}
  2. Added support for each row through a class:.dt-row, which can be nested and applied only to the corresponding panel:

image

@vitPinchuk vitPinchuk requested a review from asimonok February 23, 2024 09:47
@vitPinchuk vitPinchuk self-assigned this Feb 23, 2024
@codecov Codecov
Copy link

codecov bot commented Feb 23, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.87%. Comparing base (be7bc5d) to head (4e1514e).

❗ Current head 4e1514e differs from pull request most recent head 6a0d806. Consider uploading reports for the commit 6a0d806 to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #272   +/-   ##
=======================================
  Coverage   98.87%   98.87%           
=======================================
  Files          35       35           
  Lines         446      446           
  Branches       68       68           
=======================================
  Hits          441      441           
  Misses          5        5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vitPinchuk
Copy link
Contributor Author

@asimonok ready for review

@asimonok asimonok mentioned this pull request Feb 23, 2024
Closed
asimonok
asimonok approved these changes Feb 23, 2024
View reviewed changes
Copy link
Collaborator

@asimonok asimonok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mikhail-vl ready for review

@asimonok asimonok requested a review from mikhail-vl February 23, 2024 12:58
@mikhail-vl mikhail-vl added the enhancement New feature or request label Feb 26, 2024
@mikhail-vl mikhail-vl added this to the Version 4.4.0 milestone Feb 26, 2024
@mikhail-vl mikhail-vl changed the title Update CSS for Container Add CSS class for Container Feb 26, 2024
mikhail-vl
mikhail-vl requested changes Feb 26, 2024
View reviewed changes
Copy link
Member

@mikhail-vl mikhail-vl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update.

src/components/TextPanel/TextPanel.tsx Outdated Show resolved Hide resolved
src/components/TextPanel/TextPanel.tsx Outdated Show resolved Hide resolved
@asimonok asimonok self-requested a review February 27, 2024 05:46
asimonok
asimonok approved these changes Feb 27, 2024
View reviewed changes
Copy link
Collaborator

@asimonok asimonok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mikhail-vl please review

@vitPinchuk vitPinchuk mentioned this pull request Feb 28, 2024
Merged
@asimonok asimonok requested a review from mikhail-vl February 28, 2024 13:56
@mikhail-vl mikhail-vl changed the title Add CSS class for Container Update CSS class for Container instead of a Row Mar 6, 2024
@mikhail-vl mikhail-vl changed the title Update CSS class for Container instead of a Row Update CSS class for the Container instead of a Row Mar 6, 2024
@mikhail-vl mikhail-vl changed the title Update CSS class for the Container instead of a Row Update CSS class for the Panel instead of a Row Mar 6, 2024
mikhail-vl
mikhail-vl approved these changes Mar 6, 2024
View reviewed changes
Copy link
Member

@mikhail-vl mikhail-vl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mikhail-vl mikhail-vl merged commit c2304cf into main Mar 6, 2024
4 checks passed
@mikhail-vl mikhail-vl deleted the feat/container-css branch March 6, 2024 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikhail-vl mikhail-vl mikhail-vl approved these changes

@asimonok asimonok asimonok approved these changes

Assignees

@vitPinchuk vitPinchuk

Labels
enhancement New feature or request
Projects
None yet
Milestone
Version 4.4.0
Development

Successfully merging this pull request may close these issues.

Add to container CSS
3 participants
@vitPinchuk @asimonok @mikhail-vl